Skip to content

Make occ upgrade verbose by default#28813

Merged
PVince81 merged 1 commit into
masterfrom
occ-upgrade-alwaysverbose
Aug 31, 2017
Merged

Make occ upgrade verbose by default#28813
PVince81 merged 1 commit into
masterfrom
occ-upgrade-alwaysverbose

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

Description

This will always output timestamps and also mention each market app that
is being checked through the marketplace.

The previous behavior can be set using --verbose=0. But I think the verbose mode will be useful in any case.

Related Issue

None

Motivation and Context

Often times admin just run occ upgrade thinking there will be no error and then it is too late to set a more verbose mode. Setting verbose mode by default also provides more useful info like where each app is being checked against the marketplace, so it looks more like progress than having no output for many seconds.

How Has This Been Tested?

Run occ upgrade with a few apps to be updated. You'll see entries about checking app updates against the marketplace, for each app individually.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This will always output timestamps and also mention each market app that
is being checked through the marketplace.
@PVince81 PVince81 added this to the development milestone Aug 28, 2017
@PVince81 PVince81 self-assigned this Aug 28, 2017
@tomneedham

Copy link
Copy Markdown
Contributor

Tested 👍

@tomneedham

Copy link
Copy Markdown
Contributor

How does this work with -q ?

@PVince81

Copy link
Copy Markdown
Contributor Author

@tomneedham with -q the verbosity would not be OutputInterface::VERBOSITY_NORMAL so the code block doesn't do anything.

@patrickjahns patrickjahns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

@PVince81 PVince81 merged commit 0632ed4 into master Aug 31, 2017
@PVince81 PVince81 deleted the occ-upgrade-alwaysverbose branch August 31, 2017 17:42
@PVince81

Copy link
Copy Markdown
Contributor Author

stable10: #28876

@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants